search

yurkinh / Plugin.Maui.Calendar

.NET MAUI port of XF calendar plugin
MIT License
131 stars 12 forks source link

Certain months are being cropped #57

Closed inimirpaz closed 4 months ago

inimirpaz commented 4 months ago

I.e. June 2024

immagine

This happens also in other CalendarLayouts. The Xamarin plugin added an extra row (upcoming month) at the end to prevent this behavior I guess.

yurkinh commented 4 months ago

Hi @inimirpaz Have you tried to play with margin/paddings? Cause Maui controls like grid/verticalstacklayout have spacing =0 be default

inimirpaz commented 4 months ago

Hi @yurkinh I tried playing with it (even though in the real project I am migrating to .NET MAUI I pre-processed all of my xamls to have the spacing explicitly set to 6 whenever it was not specified otherwise) but I cannot get it to display the last row. I tried to use stacklayouts, vertical, grid, nothing at all (root content of the page) and to play with the hor/ver options but nothing seems to work. Am I missing something?

Repro: https://github.com/inimirpaz/maui_issues/tree/calendar_event_issue

ross8alex commented 4 months ago

Seems to be whenever there's a 6th row it doesn't automatically expand to show that extra row.

yurkinh commented 4 months ago

Hi @inimirpaz @ross8alex Could you try this custom nuget build with fix locally? Plugin.Maui.Calendar.1.1.8.nupkg.zip

inimirpaz commented 4 months ago

Hi @yurkinh , it works as expected, thanks!

Just a side note: I launched the repro project but since the "current date" is already June the issue was not there anymore, even with the current latest stable release, the last row is shown. I had to change the current date to, say, May to have it back and test the custom nuget. Anyway, this is kind of expected.

yurkinh commented 4 months ago

Fix published with nuget version 1.1.8