yuroyami / syncplay-mobile

📱 Unofficial Syncplay client app for Android and iOS. Watch stuff in sync with your friends. Works well with Syncplay on PC. Fully written in Kotlin and Compose multiplatform.
133 stars 5 forks source link

feature request: remember selected subtitle index when changing files #51

Closed soredake closed 8 months ago

soredake commented 1 year ago

It would be nice if syncplay-android can remember selected subtitle index so i wouldn't have to select it again when next file will be played.

yuroyami commented 1 year ago

this one used to be an actual feature in previous versions, i forgot to include it again after all the revamping. i will take that into account, thanks for the reminder

yuroyami commented 9 months ago

@soredake I am not sure if this is working again in v0.13.0. Could you test it for me with both mpv and exo? I'll try to test it myself as well

soredake commented 9 months ago

@yuroyami I can't test this since shared playlist settings is broken for me https://github.com/yuroyami/syncplay-mobile/issues/87

yuroyami commented 8 months ago

@soredake It should also work when you're loading one similar file after another (since that's what happened during shared playlist index change)

soredake commented 8 months ago

Now subtitle index is remembered, it's been hard to test this since there are so many crashes in this version.

yuroyami commented 8 months ago

@soredake Do kindly report any crashes you're experiencing, I am currently using this version and it's crashing less often for me than the previous one. There are some departments that still require a lot of work to do such as the quick launch shortcuts and shared playlists

EDIT: It's worth noting that with each release, a newer version may contain incompatibilities with its previous version, so in this case it's not possible to install 0.13.0 over the 0.12.0 for example. A clean install is required.