yuroyami / syncplay-mobile

📱 Unofficial Syncplay client app for Android and iOS. Watch stuff in sync with your friends. Works well with Syncplay on PC. Fully written in Kotlin and Compose multiplatform.
113 stars 5 forks source link

Syncplay-android often can't find file in playlist if it's put in subdirectory under media directory #54

Closed soredake closed 2 months ago

soredake commented 1 year ago

If i put "/directory" into media directories list, and the put some files into "/directory/subdirectory" and add this files to playlist syncplay-android will have troubles finding them most of the time.

yuroyami commented 1 year ago

It does fail to get files sometimes which is why I'm rewriting it for the moment, also, there will be a new feature that requires the user to turn on 'All files access', to not need media directories anymore, and the app will then query the entire device instead. Given the fact that most devices are fast enough storage-wise, it will be a good alternative to manually adding media directories.

soredake commented 1 year ago

Given the fact that most devices are fast enough storage-wise,

Don't know about microsd cards with large amount of folders/files like mine.

yuroyami commented 1 year ago

@soredake It will be optional and not enforced, so media directories will always be a thing, to account for low-end devices and secondary storage like yours

Btw, does this issue happen when you're loading files from the main storage ? this might have sth to do with only secondary storages etc

Also, how often does it happen?

soredake commented 1 year ago

Btw, does this issue happen when you're loading files from the main storage ?

It seems not, tried several adding several files from internal storage, all loaded fine.

this might have sth to do with only secondary storages etc

I discovered reason why file is not loading, if i join room with only one playlist item it will not load from internal storage or microsd, adding another file to playlist and switching files makes first playlist item load fine until restart.

yuroyami commented 1 year ago

Noted, thanks for the troubleshooting

soredake commented 1 year ago

Also this bug makes me unable to switch playlist items, it will just stay on currently open file, even if i remove this playlist item.

yuroyami commented 1 year ago

@soredake, revamping broke many stuff, i will revisit the whole shared playlist thing since i just decided to perform a complete re-write on it. Thanks for bringing this to light

soredake commented 1 year ago

I've updated issue title and description.

yuroyami commented 2 months ago

Though shared playlists are still "incubating" and unstable, the whole tree inside a media directory is searched in v0.14.0.