yurpcraft / wotlkbeta-mage

0 stars 0 forks source link

Molten armor, when glyphed, will "snapshot" even after you switch specs #27

Open yurpcraft opened 2 years ago

yurpcraft commented 2 years ago

1. Current Behavior

1.1. Description

{Describe how that mechanic/spell/npc is currently working, in detail}

Rank 1 Molten Armor is appropriately applying a spirit to crit conversion at the documented rate (for example, 317 + (3240.35) = 430). When Glyphed, Molten Armor also applies the appropriate spirit to crit conversion (317 + (3240.55) = 495). However, when using dual spec to change specs, the glyphed crit value will remain on the "snapshot" of the applied molten armor buff.

1.2. How to Reproduce

       1. Glyph Molten Armor
       2. Apply Molten Armor buff
       3. Switch to second spec without the Glyph of Molten Armor

1.3 Source Material

Video + screenshots available via discord, some additional documentation available here: https://github.com/yurpcraft/wotlkbeta-mage/issues/24

2. Expected Behavior

2.1. Description

Molten armor's glyphed spirit to crit conversion should not be applied when operating a spec that does not have the molten armor glyph. This is a similar bug to how the death knight Hysteria buff was able to be applied as the death knight switched specs.

2.2 Source Material

yurpcraft commented 1 year ago

Molten armor will no longer snapshot and keep the increased crit when glyphed and the spec is switched