search

yury-dymov / react-autocomplete-input

Autocomplete input field for React
https://yury-dymov.github.io/react-autocomplete-input/
MIT License
199 stars 65 forks source link

Feature Request: position #17

Closed kafeltz closed 6 years ago

kafeltz commented 6 years ago

I wonder if it be easy to add a position like north, south, east and west for the popup when pressing @.

Currently the component has offsetX and offsetY, but this is not enough. I'm in a need to show the popup above the input field because I have no space to show at the bottom.

I could do a PR but would be nice to discuss this a little bit before coding.

yury-dymov commented 6 years ago

Sounds more like a very specific use-case, rather than something that might be valuable for many. Feel free to file the PR, maybe your code will help to change my opinion.

kafeltz commented 6 years ago

I toke a look in the code and I changed the CSS and it's very easy to do it. Just change the CSS attribute top to bottom.

Take a look in the line 363.

Still, I think the list shown in the popup should be inverse ordered because the first match it will be in the top instead close to the textarea.

The result it will be: image

And without, as it is right now it is like this: image

Well, it will work for me. I'm not sure if could potentially mess up with other users.

yury-dymov commented 6 years ago

Looks convincing :)

Well, I want to keep the default behavior as it is but now I don't mind to have an option to control the options block position. Feel free to file a PR.