Open vighnesh153 opened 1 year ago
Sounds a interesting feature.
I believe the usage of the feature could be:
https://github.com/yusanshi/emgithub/commit/86f230a6bc37805b6186b355a41b075c123d97d9
https://github.com/yusanshi/emgithub/commit/86f230a6bc37805b6186b355a41b075c123d97d9#diff-36cec0a19fd4229769211afcfd94c3aad3e3a98882aa0f68cdf9e836b0cbc4f8
Also the PR can be included as they are quite the same logic. For exampe: https://github.com/yusanshi/emgithub/pull/22/files.
And surely the github.com
=>emgithub.com
for quickly jumping should still work for this feature.
However the implementation may not be easy. Currently all the three existing modes are implemented by fetching the contents from GitHub and rendering them ourselves. We need write our rendering code but this give us more freedom for customization (e.g., code hightlighting style).
But rendering the commit diff seems somewhat complicated. After some searching, I think we can:
iframe
. But it seems to have lots of limitations and I'm not sure whether it works well.But currently I may not have the time to implement this (Maybe after serveral months). Anyway I'll mark this as help-wanted.
Thanks a ton for this amazing tool. 1 feature I feel would be a cherry on top, would be to have support for embedding commit diffs.
Feature requests
For example, if you check this link: https://github.com/yusanshi/emgithub/commit/6ffceea50ef2ea89916dc066f365c211a5ea367f
It displays as displayed in the following image.