search

yushijinhun / authlib-injector

Build your own Minecraft authentication system.
https://authlib-injector.yushi.moe
GNU Affero General Public License v3.0
728 stars 66 forks source link

fix 1.20.2 can not view skin #226

Closed xmdhs closed 8 months ago

xmdhs commented 8 months ago

1.20.2 更新了 authlib 版本，并把 Property 改为 record 类。且 net.minecraft.client.resources.SkinManager 中改成了默认获取带有签名的皮肤，导致在 1.20.2 无法加载皮肤。

这个 pr 尝试修复这个问题，我对于 javaagent 不是很了解，这样判断应该有些问题。我自己的测试中皮肤是已经可以加载，服务器中也是。

issues: #225

xmdhs commented 8 months ago

改成为 Property 添加回 getter，麻烦看看有什么问题

yushijinhun commented 8 months ago

Thank you for the pull request. I've actually implemented a different solution to address the bug (https://github.com/yushijinhun/authlib-injector/commit/f6970a51b2b1974b90e43d3786e55dcef04d6a8e).