search

yusifsalam / t490-macos

Lenovo T490 running macOS Big Sur using OpenCore
111 stars 38 forks source link

Update README.md #8

Closed denzilferreira closed 4 years ago

denzilferreira commented 4 years ago
yusifsalam commented 4 years ago

Thanks Denzil, appreciate your contribution!

EDIT: Nevermind, I just realized that my suggestion creates more confusion, since the actual file name would not match the description in readme.
One change I would like to request is that you remove airport itlwm from kext descriptions, since it's just a build of itlwm, which I already have a description for. I do agree that it should probably be stated that it's a beta airport build though, so maybe just change the description for itlwm :)

yusifsalam commented 4 years ago

A bit unrelated but I peeped your fork and noticed you committed a gitignore for DS_Store files. I have that added to my global gitignore, which I recommend you do as well, since those files are littered everywhere on macOS.

yusifsalam commented 4 years ago

I forgot to ask, did you test everything with my config file or did you make any changes other than the serial?

denzilferreira commented 4 years ago

Exactly your config with my own serial generated. I later edited the config to remove Arch and Win10 from the menu but that’s all. You can make the edits you mentioned on the README as I would only be on my pc tomorrow now :)

> sudo mail from:Denzil

> Sent successful (elapsed .001 seconds)

On 17. Sep 2020, at 22.35, Yusif Salam-zade notifications@github.com wrote:

 I forgot to ask, did you test everything with my config file or did you make any changes other than the serial?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

denzilferreira commented 4 years ago

Forgot to say: Personal Hotspot also works now from my iPhone, AirDrop too. I no longer have drops on my Airpods Pro either. Getting close to perfection!

> sudo mail from:Denzil

> Sent successful (elapsed .001 seconds)

On 17. Sep 2020, at 22.52, Denzil Ferreira ferreiradenzil@gmail.com wrote:

Exactly your config with my own serial generated. I later edited the config to remove Arch and Win10 from the menu but that’s all. You can make the edits you mentioned on the README as I would only be on my pc tomorrow now :)

> sudo mail from:Denzil

> Sent successful (elapsed .001 seconds)

On 17. Sep 2020, at 22.35, Yusif Salam-zade notifications@github.com wrote:

 I forgot to ask, did you test everything with my config file or did you make any changes other than the serial?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

yusifsalam commented 4 years ago

Forgot to say: Personal Hotspot also works now from my iPhone, AirDrop too. I no longer have drops on my Airpods Pro either. Getting close to perfection!

Did you build the kext from the latest commit or use the one in the release? On my machine AirDrop doesn't work on the release version kext.

denzilferreira commented 4 years ago

Hum... this is so strange... Yesterday, I could see my phone's personal hotspot and AirDrop between my phone and laptop. Now I can't... I did update last night to iOS 14 on my phone... I wonder if that's why? 👎

yusifsalam commented 4 years ago

It's a known issue so I wouldn't worry about it too much, we just have to wait until a stable version of airport itlwm is released. (Unless you really need the hotspot feature, in which case you should revert to normal itlwm).