search

yusitnikov / fix-webm-duration

navigator.mediaDevices.getUserMedia + MediaRecorder create WEBM files without duration metadata. This library appends missing metadata section right to the file blob.
MIT License
259 stars 50 forks source link

Purge console.logs #6

Closed wrbl606 closed 3 years ago

wrbl606 commented 3 years ago

It does a great job, but printing logs each time it works without a way to make it silent does break my current logging system.

yusitnikov commented 3 years ago

Hi Marcin, thanks for the contribution and sorry for the huge delay in my response.

I think that logs still should be available for those who need them. So I'm rejecting this PR, but I made a change to the library (available since v1.0.1) - now the function accepts options argument, and one of the options is logger, so you can specify a custom logger callback instead of console.log (which is still the default) or disable the logging completely by passing false. See the updated docs for more details and examples.

wrbl606 commented 3 years ago

Great, thanks! 👍