yusufaine / pe

0 stars 0 forks source link

[abstracting common functionality] managing candidates and scheduling interviews #11

Open yusufaine opened 2 years ago

yusufaine commented 2 years ago

Seeing as how candidates and schedule has similar CRUD functionality, I think it would be easier for the user to specify a special flag/prefix to denote whether an action is done for candidate or interviews. The need to specify schedule feels a bit unnecessary, considering CLI applications also use flags/prefix to denote accordingly

Example:


image.png

soc-se-bot commented 2 years ago

Team's Response

This appears to be more of a suggestion rather than a functionality bug because it does not affect the correctness of our program, nor is it considered as missing a critical functionality to be counted as a feature flaw.

Screenshot 2022-04-17 at 21.35.09.png

Nonetheless, we have edited the type to feature flaw out of goodwill, and in the worst case scenario, should the tester/TA not agree, we can consider it as a NotInScope feature flaw because rectifying it is considered less important than the work done (i.e. this suggestion if considered, could be delayed to future iterations), as per the guidelines.

Screenshot 2022-04-17 at 22.45.25.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: While I appreciate and respect that the team has graciously accepted this issue as a feature flaw, the point I wanted to make/highlight was that this could have been addressed in the brainstorming stage of the app development, considering how they were so similar in nature, and might have been a user story that the could address.