search

yusufaine / pe

0 stars 0 forks source link

[schedule-add] minor issue on the feedback message -- not sure what is "invalid" about this command based off the error message #3

Open yusufaine opened 2 years ago

yusufaine commented 2 years ago

This is a very small nit, but I think it would be good if the error message can indicate which part of the date-time is invalid

image.png

nus-pe-script commented 2 years ago

Team's Response

rejected because clearly and logically the time given is invalid 23:69 does not exist. And there are not that many parameters in the argument as well that would otherwise make it difficult for the user to identify the invalid input as the time given.

current error message to deal with inputs is considered sufficient. Improvements would be out of scope.

Screenshot 2022-04-17 at 9.33.05 PM.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]

:question: Issue type

Team chose [type.FunctionalityBug] Originally [type.FeatureFlaw]

Reason for disagreement: [replace this with your explanation]