search

yusufaine / pe

0 stars 0 forks source link

[clear] confirmation message/prompt #6

Open yusufaine opened 2 years ago

yusufaine commented 2 years ago

Clear is a very power command which works as intended, but it would be unfortunate if a user clears all their data without some sort of confirmation message.

image.png

Suggestions:

  1. Confirmation message
    • Specific command to bypass confirmation clear -f
  2. undo command
soc-pe-bot commented 2 years ago

Team's Response

Users should have been aware about the functionality of each command from the UG. Otherwise, it could be argued that other commands such as deleting and editing should be given a warning since they are irreversible as well.

While we accepted most suggestions given to us as a FeatureFlaw that is OutOfScope, this seems to be a stretch as our target users are professors in NUS who are tech-savvy. We do not see any reason why they would accidentally enter the clear command - in fact there are no commands that are similar to clear that would lead them to entering the command on accident, with the closest being schedule clear, which is still very far off.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: > it could be argued that other commands such as deleting and editing should be given a warning since they are irreversible as well.

  1. I stand corrected, it would have been a better idea to have included an undo command (which was suggested at the bottom) instead of enforcing a confirmation for clear. It seems pretty important that the users are able to undo state changes (addition/deletion/modification) to the application whether the changes were deliberate or otherwise. Doing so would also prevent the need for confirmation messages for deleting and editing.

this seems to be a stretch as our target users are professors in NUS who are tech-savvy. We do not see any reason why they would accidentally enter the clear command

  1. While I agree that NUS professors (SOC, at that) are tech-savvy, saying that they would not accidentally issue clear also seems like a stretch to me. They may be using different applications that also have clear (such as terminal/command prompt), and not realise that TAlentAssistant was in focus instead of the application that they were intending to use. clear is a quick command to execute and whether it was done on the terminal or TAlentAssistant may really ruin the professor's day (more use case for [1]). Personally speaking, there have been times during the building of my own application where I thought I had my application open but did not realise that the code editor was in focus and vice versa, and I believe that this scenario isn't unique to me.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: I feel like the team did not address a medium-/high-level use case that the users might encounter. Initially it was due to clear not having a confirmation message which I felt might cause some accidents and result to the user needing to re-enter the lost data. However, the team has also pointed out in their response that if this was the case, commands such related to deleting and editing. This, in fact, may result it to a higher severity.