search

yusufaine / pe

0 stars 0 forks source link

[ug-clear] clear should warn users about how there isn't a way to confirm the command or the actions cannot be undone #7

Open yusufaine opened 2 years ago

yusufaine commented 2 years ago

Caution message was used for "Editing the data file", and I feel like clear warrants a caution message as well

image.png

nus-se-script commented 2 years ago

Team's Response

Users should have been aware about the functionality of each command from the UG. Otherwise, it could be argued that other commands such as deleting and editing should be given a warning since they are irreversible as well.

Warning was given for editing JSON files in the UG because the user is not supposed to edit it manually in the first place.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: > Warning was given for editing JSON files in the UG because the user is not supposed to edit it manually in the first place.

The screenshot also mentions how "advanced users are welcome to update data directly by editing that data file", so I'm not too sure about the validity of the argument of whether users are "not supposed to". It seems like the purpose of that caution message is to inform users of what would happen if the JSON format is invalid/violated/corrupted.

I still stand by my opinion that clear should still include a warning message so as to highlight that there may be negative repercussions if it were to be executed blindly, and am disagreeing with this on the grounds that the clear section was not as informative as it should have acceptably been.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Lack of warning may result in users blindly clearing all their data which is bad as there is no confirmation message or undo feature.