Closed hanchchch closed 8 months ago
Thanks for your kind words and your contribution. Would you be interested in writing a unit test for func (s *Suggest) refineCommand(command string) string
as well? This is what I'm gonna do before approving it.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
No data about Duplication
Sure, I just added it. Note that I had to write it in suggest
package instead of suggest_test
, because the refineCommand
method is not exported.
Thank you for your contribution! ❤
Hi, thank you for building and publishing this fascinating cli app. I had a tiny issue with
suggest
command. llama puts a shell prefix such as$
or❯
sometimes, like below.It's not very often but it's disrupting the experience since you can't execute the command right after the suggestion when it happens.
I made a small solution simply by trimming the shell prefix if exists. I think it can be more developed like adding below method.
Because the generated commands are not always perfect, it would be helpful to handle known/possible issues.