search

yusukebe / revealgo

Markdown driven presentation tool written in Go!
MIT License
237 stars 22 forks source link

Add GitHub actions for CI and Release processes #20

Closed jossemarGT closed 2 years ago

jossemarGT commented 2 years ago

Ok, this pull request was created as a draft on on purpose due to:

  1. When a contributor adds a github action, I recall the maintainer must approve it first, berfore it start working.
  2. I need to discuss some details about how do you (@yusukebe) imagine the release process should look like.

I think the fastest approach would be to let gorelease to create the release on GitHub by itself, this is supported by it out of the box. The relase will be triggered when a git tag is pushed, and this will be created as a draft or pre-release so you can manually change anything you like aftewards.

What do you think? Should we go that way or do you have other idea?

And yes, you will need to test the process with a dummy release (ie: v1.1.1 or v1.2.0-pre)

PS: I will clean up the branch history after we agree on how to proceed.

yusukebe commented 2 years ago

Hey @jossemarGT.

I totally agree with the release process you suggest in this draft PR. Let's go to the next step. Would you create a Pull Request that is not a draft, and I will test with a dummy release.

Thank you!

jossemarGT commented 2 years ago

Hey @yusukebe , sorry for the delay. Everything has been sorted out. I tested it the goreleaser configurations against my own fork and it worked as expected; now it is only matter of testing it on your side. You will need to create a new git tag into this repository and wait for the github action to do its magic.

Screenshot_20211030_143907

PS: For external readers context, this feature already had been discussed on #11

yusukebe commented 2 years ago

Thank you @jossemarGT! I fixed some issues ( 1b67ba235365c69b80538a9d88c1d38fbd737058, #22 ) , try to release by creating new tag, and it has been succeeded! Let's go this way.

jossemarGT commented 2 years ago

Oh my! :man_facepalming: @yusukebe those 2 configurations totally slip my mind, I was sure those were there. Anyhow, I am happy you were able to sort it out.