search

yusukebe / revealgo

Markdown driven presentation tool written in Go!
MIT License
237 stars 22 forks source link

Deprecate go-bindata in favor of Go embed #5

Closed jossemarGT closed 3 years ago

jossemarGT commented 3 years ago

Hey! Funny story, days ago I was about to retake a personal old project that had the same objective as yours but delivered far less than revealgo :sweat_smile:. It was a no brainer to throw away that old project and look on what I could help over here.

Since I do not want to be too disruptive I did a couple of small changes. Starting with using Go embed instead of go-bindata for the assets. I have already tested it locally and it is working, so please let me know what do you think about it.

Regards,

PS: Have you think on adding WebSockets support and enable the multiplex revealjs plugin? It does not seems that simple but I tempted to give it a try.

yusukebe commented 3 years ago

I was considering to use Go embed instead of go-bindata. So, welcome your request! I did not think about enable multiplex revealjs plugin. But possibly I will think about support WebSockets.

Thank you!

jossemarGT commented 3 years ago

I did not think about enable multiplex revealjs plugin. But possibly I will think about support WebSockets.

Oh great, in that case I might submit another PR for it. I just needed to confirm if that was OK with the maintainer.