search

yutakahirano / fetch-with-streams

Fetch API integrated with Streams.
66 stars 8 forks source link

Define streams common operations in Infrastracture section. #54

Closed yutakahirano closed 9 years ago

yutakahirano commented 9 years ago

This is a refactoring effort. Addressing #52.

domenic commented 9 years ago

So, this over all looks pretty reasonable, but it doesn't actually address the biggest part of #52, which is IDL vs. JS values. Each defined algorithm probably needs a step at the beginning converting inputs into JS values and a step at the end converting outputs into IDL values. (Or, a blanket "in these steps we conflate IDL and JS values" disclaimer.)

yutakahirano commented 9 years ago

@domenic

In #50 and #52 some solutions were proposed and we didn't choose one. I would like to collect JS-stream related definitions in one place so that we can deal with the problem easily in the future (i.e. I won't close #52 after this PR is landed, but add "not-included-in-the-first-release" label to it and start creating merge PRs).

I can add "we don't distinguish JS-stream and IDL-stream as of now" note in this PR.

yutakahirano commented 9 years ago

@domenic, are you fine with this change?

domenic commented 9 years ago

Yes, LGTM with some minor comments. Good stuff.

yutakahirano commented 9 years ago

Thank you!