Reuest.body value after passed to another Request

yutakahirano commented 8 years ago

req2 = new Request(req);

At https://github.com/whatwg/fetch/issues/61, we agreed that

req.bodyUsed should be false if req had null body, and
req.bodyUsed should be true if req had a non-null body.

Anne proposed to introduce obsolete flag in order to make req.body null and req.bodyUsed true after passing the body, but it looks like another passed flag we replaced with ReadableStream.IsDisturbed. @jakearchibald's piping idea sounds cleaner to me and ideally it should work, but I'm not sure about its performance.

Thoughts?

cc: @domenic @wanderview @tyoshino

yutakahirano commented 8 years ago

cc: @annevk

annevk commented 8 years ago

I'm okay either way. I guess someone should measure the performance of doing piping if we are fine gating on that?

domenic commented 8 years ago

Is this solved currently? I lost track. If it is not, it probably can be solved similarly to https://github.com/slightlyoff/ServiceWorker/pull/934 ?

yutakahirano commented 8 years ago

It's not yet solved, and it should be solved as same as https://github.com/slightlyoff/ServiceWorker/pull/934.

annevk commented 7 years ago

What is the status of this issue? I missed it while merging in stream-based requests.

yutakahirano / fetch-with-streams

Reuest.body value after passed to another Request #60