search

yutannihilation / datafusion-r

Other
8 stars 0 forks source link

Reconsider R Class names (and struct names in Rust)? #3

Closed eitsupi closed 1 month ago

eitsupi commented 1 month ago

I don't know if this applies here, but early in the development of the polars package there was a class name conflict with the arrow package (pola-rs/r-polars#11).

So I always prefix class names with the package name...

yutannihilation commented 1 month ago

Which one do you mean in particular? RDataFrame is not unique enough? Or, is this a problem I will face in future, not now?

eitsupi commented 1 month ago

Which one do you mean in particular? RDataFrame is not unique enough? Or, is this a problem I will face in future, not now?

Of course, it's not a problem right now, but rather a potential problem in the future - RDataFrame and RExpr could be chosen to create bindings for things like Polars or DataFusion, in which case they would conflict.

yutannihilation commented 1 month ago

Thanks, noted. Okay, let's choose redundant names.