Issues with next version of ggplot2

[thomasp85]

One of the ggplot2 reverse dependencies fails with the release candidate of ggplot2 due to what seems to be an issue in gghighlight based on my cursory glance. Will you have time to look into this?

> revdepcheck::cloud_details(, 'cricketdata')
══ Reverse dependency check ═══════════════════════════════════════ cricketdata 0.2.0 ══

Status: BROKEN

── Still failing

✖ checking data for non-ASCII characters ... NOTE

── Newly failing

✖ checking re-building of vignette outputs ... WARNING

── Before ──────────────────────────────────────────────────────────────────────────────
❯ checking data for non-ASCII characters ... NOTE
    Note: found 34 marked UTF-8 strings

0 errors ✔ | 0 warnings ✔ | 1 note ✖

── After ───────────────────────────────────────────────────────────────────────────────
❯ checking re-building of vignette outputs ... WARNING
  Error(s) in re-building vignettes:
    ...
  --- re-building ‘cricinfo.Rmd’ using rmarkdown
  `geom_smooth()` using method = 'gam' and formula = 'y ~ s(x, bs = "cs")'
  Warning: Removed 2574 rows containing non-finite values (`stat_smooth()`).
  Warning: Removed 2574 rows containing missing values (`geom_point()`).
  --- finished re-building ‘cricinfo.Rmd’

  --- re-building ‘cricsheet.Rmd’ using rmarkdown
  Quitting from lines 112-148 (cricsheet.Rmd) 
  Error: processing vignette 'cricsheet.Rmd' failed with diagnostics:
  non-finite location and/or size for viewport
  --- failed re-building ‘cricsheet.Rmd’

  SUMMARY: processing the following file failed:
    ‘cricsheet.Rmd’

  Error: Vignette re-building failed.
  Execution halted

❯ checking data for non-ASCII characters ... NOTE
    Note: found 34 marked UTF-8 strings

[yutannihilation]

Sure, I'll investigate.

[thomasp85]

never mind - I found the root cause... will be fixed in ggplot2