search

yutasuzuki / react-native-record-screen

react-native-record-screen
MIT License
149 stars 40 forks source link

Update HBRecorder to v3.0.3 #121

Closed robrechtme closed 6 months ago

robrechtme commented 7 months ago

Hi 👋

This MR attempts to update HBRecorder to v3.0.2 in order to fix https://github.com/yutasuzuki/react-native-record-screen/issues/117. I've also bumped the example to RN 0.73 using the upgrade helper. I am still having some trouble getting this version to run correctly. I'm getting the following error and I can't seem to figure out what goes wrong 🤔 

android/src/main/java/com/recordscreen/RecordScreenModule.kt:14:12 Unresolved reference: hbisoft
robrechtme commented 7 months ago

Seems the issue is related to the library itself: https://github.com/HBiSoft/HBRecorder/issues/158

robrechtme commented 7 months ago

It is fixed in 3.0.3! So this is ready to be reviewed.

yutasuzuki commented 7 months ago

@robrechtme Thanks! Did the React Native update have any impact on iOS?

yutasuzuki commented 6 months ago

@robrechtme I have confirmed that iOS works. Thank you!!