search

yutasuzuki / react-native-record-screen

react-native-record-screen
MIT License
149 stars 40 forks source link

feat: allow different minSdkVersion #87

Closed robrechtme closed 1 year ago

robrechtme commented 1 year ago

Hi

Is there a reason the minSdkVersion is at 26? When I look at HBRecorder the min API level is 21.

This PR allows the minSdkVersion field to be overridden.

yutasuzuki commented 1 year ago

@robrechtme Thanks for the PR. No reason given. It was a result of trial and error. At the time of development (and still today), I had no knowledge of android development. I am currently busy, so it may take some time to confirm.

robrechtme commented 1 year ago

Hi @yutasuzuki

We checked on an Android 7 device (API level 21), and it seems to work fine.