search

yutingzou / pe

0 stars 0 forks source link

Meaningless parameter in DG 4.8 Delete multiple tasks with an index range, sequence diagram #10

Open yutingzou opened 3 years ago

yutingzou commented 3 years ago

The meaning of '...' is ambiguous and getTaskToDelete() needs to return a matched task for deleteTaskFromModel() to execute.

Screenshot 2021-04-16 at 3.31.31 PM.png

nus-pe-bot commented 3 years ago

Team's Response

The (...) is used for the sake of brevity. There is no need to put so many unnecessary details into the sequence diagram. The diagram may seem too cluttered. The method getTaskToDelete() without explicit arguments will not cause any misunderstanding on how the feature works

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]