fixture_file_upload で指定するpathが間違ってないかな？

yutokyokutyo commented 7 years ago

ref: https://www.railstutorial.org/book/user_microposts#code-image_upload_test

picture = fixture_file_upload('test/fixutures/rails.png', 'image/png') の test/fixutures/rails.png というpathが間違っている。それも含めて演習問題なのかなぁ？

実際はテストしたい画像は rebuild_sample_app/test/fixtures/rails.png にある。
テストでは rebuild_sample_app/test/fixtures/test/fixutures/rails.png を見てしまってエラーになる。

% rails t                                                                                                                    (git)-[Exercises-13.4.1]
Running via Spring preloader in process 385
Started with run options --seed 33363

ERROR["test_micropost_interface", MicropostsInterfaceTest, 4.024783941000351]
 test_micropost_interface#MicropostsInterfaceTest (4.02s)
RuntimeError:         RuntimeError: /Users/y.kondo/project/workspace/rebuild_sample_app/test/fixtures/test/fixutures/rails.png file does not exist
            test/integration/microposts_interface_test.rb:21:in `block in <class:MicropostsInterfaceTest>'

  58/58: [=======================================================================================================] 100% Time: 00:00:05, Time: 00:00:05

Finished in 5.24186s
58 tests, 307 assertions, 0 failures, 1 errors, 0 skips

yutokyokutyo commented 7 years ago

before

picture = fixture_file_upload('test/fixutures/rails.png', 'image/png')

after

path はtest/fixutresから見て相対パスを書くべきなのでこれでテストが通る。

picture = fixture_file_upload('rails.png', 'image/png')

% rails t                                                                                                                    (git)-[Exercises-13.4.1]
Running via Spring preloader in process 1180
Started with run options --seed 34034

  58/58: [=======================================================================================================] 100% Time: 00:00:05, Time: 00:00:05

Finished in 5.64494s
58 tests, 315 assertions, 0 failures, 0 errors, 0 skips

yutokyokutyo commented 7 years ago

`fixture_file_upload`について

yutokyokutyo commented 7 years ago

% rails --version                                                                                                             (git)-[user-microposts]
Rails 5.0.2

yutokyokutyo commented 7 years ago

https://github.com/matthewd/rails/commit/333f10e32c0b8cbaf4dbaaee3333d21b138a7d4a

yutokyokutyo commented 7 years ago

Rails5.0.1ではテストが通るっぽいのでこの辺も調べてみる。 https://github.com/rails/rails/compare/v5.0.1...v5.0.2

yutokyokutyo / rebuild_sample_app