Fix support for mobile devices

yuvadm / free-haaretz

A nefarious browser extension that easily bypasses the haaretz{.co.il,.com} paywall

157 stars 20 forks source link

Fix support for mobile devices #19

Closed Qsuare closed 6 years ago

Qsuare commented 7 years ago

Using googlebot user agent on mobile is forcing haaretz's desktop site. It doesn't if we use the Googlebot (Smartphone) user agent (https://support.google.com/webmasters/answer/1061943?hl=en). I've changed the user string under a custom user agent extension in firefox mobile, and it's working, but I didn't manage to test this pull request as I'm struggling with installing the built .xpi file. Please test it before making any changes.

yuvadm commented 7 years ago

Thanks, I might adapt this patch a bit, but will definitely take your suggestion

roded commented 6 years ago

Would be great if this was fixed. Any help needed with this issue?

yuvadm commented 6 years ago

@roded thanks for offering to help! If you cleanup the patch and update the code I'll be happy to merge. Specifically:

[ ] Rebase on master branch (probably easy)
[ ] Find a good way to differentiate desktop / mobile clients (not sure this current suggestion is good enough)
[ ] Extract user agents to a nice config something like:

USER_AGENTS = {
    'mobile': 'foo',
    'desktop': 'goo'
}

yuvadm commented 6 years ago

Fixed in #25