search

yuvadm / free-haaretz

A nefarious browser extension that easily bypasses the haaretz{.co.il,.com} paywall
158 stars 19 forks source link

0.93 xpi appears to be corrupt(?) #20

Closed ItayHadas closed 6 years ago

ItayHadas commented 7 years ago

hi, trying to install the 0.93 xpi on firefox 53 x64 for windows- shows "the add-on could not be installed because it appears to be corrupt" the same xpi installed successfully on my firefox for android.

THANKS!!!

yuvadm commented 7 years ago

Do other versions work? Did the file download properly?

ItayHadas commented 7 years ago

I use your addon for years - it worked wonderfully - Thanks! right now, when trying to install versions 0.9 - 0.93 on two different computers or on a fresh firefox profile it shows the corrupt issue.

what am i doing wrong?

Thanks for your time!

yuvadm commented 7 years ago

@jorjio one more debugging step, try downloading the chrome ZIP, renaming it to an XPI, and try installing it (it will warn about it being unsigned, let it continue). Does that work?

ItayHadas commented 7 years ago

no, it doesn't work (renaming the chrome zip to xpi) same error message as before "...appears to be corrupt"

thanks.

yuvadm commented 7 years ago

Reproduced this on another Windows machine. Doesn't seem to happen on Linux though.

yuvadm commented 7 years ago

@jorjio can you please test v0.9.4? BTW it doesn't reproduce for me on Windows 10 32-bit on a VM.

ItayHadas commented 7 years ago

sorry, same issue. Now it wont install on my android firefox also (0.93 did got install successfully on android- only it forced a desktop versionof the website, and later it gave warning issue by the haaretz website itself - i guess they became aware of your addon). btw i'm using firefox 54 - but i'm able to install unsigned extensions- for instance from github directly..

thanks! (i accidentally closed the issue)

yuvadm commented 7 years ago
  1. Which warning did you get? There are several possible warnings I can think of.
  2. This extension is definitely signed, it's just not distributed via the Mozilla Store.
  3. I still haven't pushed a version that handles mobile user agents properly, will get to it soon.
ItayHadas commented 7 years ago

1. 1384194_10151996632088665_902938707_n i cant recreate this message right now - but i downloaded from a facebook group the same one i got (attached - mine was in english).

  1. excuse me, i'm completely clueless on these matters - but i red somewhere that you should compress the xpi using zip deflate, and only then sign it - i'm just throwing it out there, i dont really know what i'm talking about.
  2. looking forward to your mobile version
yuvadm commented 6 years ago

This seems to be an old issue, I'm closing it. Please re-open this issue or a new one with further details if the latest release is buggy.