search

yuvadm / free-haaretz

A nefarious browser extension that easily bypasses the haaretz{.co.il,.com} paywall
158 stars 19 forks source link

Mobile support #25

Closed roded closed 6 years ago

roded commented 6 years ago

19 continued.

I'm not convinced regarding the mobile detection either. But short of including a device-detection library which will regexp the user-agent, it seems like checking orientation should work appropriately. MDN suggest checking the Navigator object's maxTouchPoints property (https://developer.mozilla.org/en-US/docs/Web/HTTP/Browser_detection_using_the_user_agent) but that seems lacking as touch screen laptops are common.

For your consideration.

yuvadm commented 6 years ago

Looks great, thanks!

roded commented 6 years ago

Great, sure thing. When can a new build be expected?

yuvadm commented 6 years ago

I'll try to do a release this weekend, hopefully tomorrow

roded commented 6 years ago

Hi, any update on a new build? Thanks!

yuvadm commented 6 years ago

@roded Sorry this fell between the cracks, expect a release over the next hour

roded commented 6 years ago

No worries & many thanks

yuvadm commented 6 years ago

@roded Done! v0.9.7 released

roded commented 6 years ago

Great! Mobile works just fine according to my tests.