search

yuvaltassa / mmx

Multithreaded matrix operations on N-D arrays (a Matlab plug-in)
MIT License
14 stars 5 forks source link

compile error on windows: expected initializer before 'teval' #1

Open AdamCooman opened 6 years ago

AdamCooman commented 6 years ago

I tried compiling from matlab 2017a on windows 10 using the MinGW64 Compiler (C).

During compilation, I get the following error

Trying to compile 'mmx_naive', using 
-DWIN_SYSTEM, 
Building with 'MinGW64 Compiler (C++)'.
Compilation of 'mmx_naive' failed with error:
C:\Users\acooman\Documents\mmx\src\mmx.cpp:80:16: error: expected initializer before 'teval'
 DWORD _stdcall teval(void* pn) 
                ^

A solution to fix this can be found on this page: https://github.com/joncox123/Cortexsys/issues/15

Fix: In mmx.cpp Line 80 add a double underscore to stdcall instead of a single one:

DWORD __stdcall teval(void* pn)

I don't know whether this will break the other builds, so I hesitate to propose this fix as a commit.

yuvaltassa commented 6 years ago

Can you please make a pull request which we'll leave floating for a while? Different users on different platforms will be able to patch it as required and let us know if it works for them (or not).

Thanks!