search

yuvipanda / hubtraf

Traffic simulator for JupyterHub
BSD 3-Clause "New" or "Revised" License
40 stars 24 forks source link

JupyterHub 4 support requires some maintenance in hubtraf it seems #36

Closed consideRatio closed 1 year ago

consideRatio commented 1 year ago

I ran into an assertion error when bumping jupyterhub to version 4 in TLJH where hubtraf is used for testing https://github.com/jupyterhub/the-littlest-jupyterhub/pull/881.

image

I figure this is related to https://github.com/jupyterhub/jupyterhub/pull/4032, which is also featured in the 4.0.0 changelog:

Often-problematic header-based checks for cross-site requests have been replaces with more standard use of XSRF tokens. Most folks shouldn’t notice this change, but if “Blocking Cross Origin API request” has been giving you headaches, this should be much improved.

Related code

https://github.com/yuvipanda/hubtraf/blob/3e8f31f446c21013fec5c7b15399dacafe61e97c/hubtraf/user.py#L211-L216

consideRatio commented 1 year ago

We seem to have a failure on TLJH's main branch still pinning jupyterhub==3.*, but I still suspect tljh fails to pin in the tests and its still jupyterhub 4 involved in this.

consideRatio commented 1 year ago

I opened https://github.com/jupyterhub/the-littlest-jupyterhub/issues/885 about the failure in TLJH, it may be entirely unrelated to hubtraf.