yuvipanda / hubtraf

Traffic simulator for JupyterHub
BSD 3-Clause "New" or "Revised" License
40 stars 24 forks source link

Remove parameter `execute_timeout` from `user.User.assert_code_output` or use it? #6

Open 1kastner opened 6 years ago

1kastner commented 6 years ago

The parameter execute_timeout from user.User.assert_code_output is not used. Should it be removed? Because there are some similarities with repeat_time_seconds. If we look at the aiohttp library documentation, I found, that a timeout could be handed in. Should that be done?