search

yuvipanda / jupyter-desktop-server

Run a Linux Desktop on a JupyterHub
BSD 3-Clause "New" or "Revised" License
46 stars 36 forks source link

add Dockerfile and adjust readme to reflect a quick start #19

Closed kniec closed 4 years ago

kniec commented 4 years ago

Took the freedom to add a Dockerfile and adjusting the readme to have a quick start (#11).

yuvipanda commented 4 years ago

Thank you for working on this, @kniec!

We currently rely on the 'apt.txt' and 'environment.yml' to do the same thing you're doing in the Dockerfile - those work on mybinder.org with repo2docker. In general I prefer that, especially over inheriting from a heavy docker image like datascience-notebook.

We could add this as an example of 'if you want to build your own Dockerfile from jupyter-stacks' or build a 'minimal Dockerfile' version. What do you think?

kniec commented 4 years ago

I changed the base image to a smaller (220MB) version of the jupyter notebook.

What would be the minimal version of the notebook you would see possible?

yuvipanda commented 4 years ago

This is more useful than what we have now, so <3 thanks @kniec! Apologies for the delayed merge.