yuvipanda / jupyterhub-ssh

SSH Access to JupyterHubs
BSD 3-Clause "New" or "Revised" License
94 stars 29 forks source link

Modernize RTD config and only build HTML docs to avoid issues #20

Closed consideRatio closed 4 years ago

consideRatio commented 4 years ago

This was mostly copied from Z2JH, which I wanted to do since I know some errors are caused by including RTD builds of other formats which are just too troublesome to debug in order to motivate doing it I think.

GeorgianaElena commented 4 years ago

Thanks @consideRatio :heart:

Not related to this PR necessarily, but I just noticed that the RTD build for this PR didn't trigger :confused: Do you remember if there was anything else to be done to activate the RTD builds for PRs except for ticking the corresponding box on the RTD website? Maybe authorizing it somehow for this repo :thinking:

consideRatio commented 4 years ago

Since this PR is modifying configuration of RTD, I don't want to debug it too much until we have merged this.

I think two things need to be done though:

  1. PR build checkbox
  2. What is described in this issue: https://github.com/jupyterhub/oauthenticator/issues/347