search

yuvipanda / jupyterhub-ssh

SSH Access to JupyterHubs
BSD 3-Clause "New" or "Revised" License
93 stars 29 forks source link

Made ssh connection timeout configureable #36

Closed cocampbe closed 3 years ago

cocampbe commented 3 years ago

It's likely not the most elegant way to do this, but it is working. One issue I kept running into is that k8s does not like integers for values. So I had to use a workaround in the config to get it to work. The other option I would be to put jupyterhub_ssh_config.py in a configmap and put that in the deployment. I almost think that is the better route.

cocampbe commented 3 years ago

@consideRatio Totally agree. I was rushing to get this working and it's a lot of code to understand from a person not working with the project.

I found this project while trying to find a way for users to be able to use vscode using the remote connection. I found that it does not work in the current implementation. Vscode creates a tunnel to make the remote connection work over ssh.

I needed a way to increase the timeout because the pod takes approx 45 seconds to start.

I can cancel my pull request. I wasn't sure how active this project is and most of the issues were opened by the maintainers. I appreciate the work. When tunneling is added, our developers will be very happy.