search

yuvipanda / jupyterhub-ssh

SSH Access to JupyterHubs
BSD 3-Clause "New" or "Revised" License
93 stars 29 forks source link

ssh: automatically cast hub_url to a yarl.URL object #53

Closed consideRatio closed 3 years ago

consideRatio commented 3 years ago
yuvipanda commented 3 years ago

@consideRatio I've made some suggestions to the docstrings. Happy to merge once we figure out what to do with them.

yuvipanda commented 3 years ago

@consideRatio ok I'm happy to merge this once the pre-commit test passes!

consideRatio commented 3 years ago

@yuvipanda it is fixed by my code suggestion!

yuvipanda commented 3 years ago

Ah cool! Merged, @consideRatio!