search

yuvipanda / jupyterhub-ssh

SSH Access to JupyterHubs
BSD 3-Clause "New" or "Revised" License
94 stars 29 forks source link

Handle websocket reconnects properly #6

Open yuvipanda opened 4 years ago

yuvipanda commented 4 years ago

Sometimes our websocket connection will die. In those circumstances, we should:

  1. Try reconnect websocket a few times, exponentially backing off with jitter. This should actually work, since terminado will maintain state.
  2. Close terminado (again, with retries) and disconnect ssh client.

We should try do this from the very beginning as much as possible