search

yuvipanda / kubessh

SSH into a kubernetes pod per user
Apache License 2.0
48 stars 11 forks source link

add rudimentary Gitlab authenticator #22

Closed mvoelske closed 4 years ago

mvoelske commented 4 years ago

Add a basic Gitlab authenticator that allows all public keys users have added to their account, just like the Github one; the only difference for now is the ability to specify a URL to a self-hosted Gitlab instance. Future API-based functionality may be worthwile, such as allowing access control via Gitlab user groups.

yuvipanda commented 4 years ago

Awesome, this is great! Thank you so much :) Do you have ideas on what to add / fix next?

mvoelske commented 4 years ago

Awesome, this is great! Thank you so much :) Do you have ideas on what to add / fix next?

You're welcome, I'm glad that it's useful! It would be nice to have a mechanism for persistent home directories -- for that, I'd simply give the UserPod a configurable pvc_template analogous to the pod_template. What do you think?

yuvipanda commented 4 years ago

@mvoelske that sounds lovely! Would love a PR for that :)