yuxshao / ptcollab

A collaborative piano-roll music sequencer!
https://yuxshao.github.io/ptcollab/
MIT License
96 stars 12 forks source link

add translations to sidebar view headers, add qtbase translation loading #112

Closed ewancg closed 1 year ago

ewancg commented 1 year ago

qtbase translation allows qmessagebox buttons ("standard buttons", as also seen in dialogs and stuff) to be translated. and probably a bunch of other stuff

translations to sidebar is self-explanatory; it looked like these translations were explicitly omitted (right next to instances where the title was translated just a few lines away, except as a tooltip). if this was intended, i'm not sure what the effect was meant to be but i think it should be translated either way. if not, oopsies

ewancg commented 1 year ago

just for the record, some of the tr calls added in the models' headers try and translate the same string as the tooltip even though they have different purposes. for example, the delay effect header shows "Freq." but when hovered it becomes "Frequency"; but right next to it, there's "Ratio" which is just displayed as "Ratio" in the tooltip. maybe it would be worth adding a disambiguation; and if one is added, how would it disambiguate? by how it's meant to be interpreted (full word vs. abbreviation), or how it's shown (table header vs. tooltip)?