search

yuxuanleong / pe

0 stars 0 forks source link

Inconsistent error message #5

Open yuxuanleong opened 2 years ago

yuxuanleong commented 2 years ago

Steps to reproduce

  1. Launch the app
  2. Type in the command edit 100 nm/edited name and press Enter.
  3. Type in the command edit 0 nm/edited name and press Enter.

Expected

Same error message for both commands

Actual

Different error message is shown

Screenshots

image.png

image.png

nus-pe-bot commented 2 years ago

Team's Response

Both error messages are still accurate. For the second input, the error message states that the index must be a positive integer.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: For both cases: edit 100 nm/edited name and edit 0 nm/edited name, as a user, I would expect both error message to be the same since the problem (invalid index provided) is the same

However, the error message for the second input is focused on invalid command and data format which means that there is a possibility that:

  1. command is in wrong format
  2. parameter tags are typed wrongly
  3. invalid parameters

Since there is a more specific error message created by the team "The index provided is invalid", it should be used for the second input too.