search

yuya373 / emacs-slack

slack client for emacs
1.11k stars 117 forks source link

support the `:display-profile-image` argument in `register-team` #505

Closed matthew-piziak closed 4 years ago

matthew-piziak commented 4 years ago

I noticed that :display-profile-image wasn't supported. Was that unintentional? If so, here is a PR to enable it. I've tested it locally and it seems to work for me.

yuya373 commented 4 years ago

According to this commit, I want to remove display-profile-image. I want to control whether to display the profile image using slack-render-image-p.

matthew-piziak commented 4 years ago

So you want those options to be coupled? Will it be possible to view images in messages, but keep profile pictures hidden?

yuya373 commented 4 years ago

So you want those options to be coupled?

yes

Will it be possible to view images in messages, but keep profile pictures hidden?

no

matthew-piziak commented 4 years ago

Fair enough! Thanks @yuya373, stay safe.