Describe the bugemojify-user-emojis contains team-specific emojis from (oref team emoji-master) but does not have the default/built-in emojis from slack-emoji-master.
Type :woman-shr and attempt to complete (via tab or whatever, depending on your completion config)
Result: no matches, but it should complete to :woman-shrugging:
Alternative steps:
Open a slack room
Find or send a message containing :woman-shrugging: (type it out by hand, since slack-insert-emoji doesn't recognize it)
Result: :woman-shrugging: is incorrectly shown as text instead of replaced by an emoji
Backtrace
Not applicable
Expected behavior
Emojis from slack-emoji-master should be added to emojify-user-emojis so that they can be inserted via slack-insert-emoji as well as rendered as an image instead of text in messages.
emacs-slack version: current master - d53a57a18fb7034182c3d02503f937761e6a2a64
emacs-emojify version: current master - 20d4fc0ea45a53f7edbe99c83317a3e048e398ef
Additional context
This is a slight tangent, but I noticed that emojis are added with style "github". Would it make sense to change it to e.g. "slack" instead? I think that would improve the UX since it would be more clear where the emojis are coming from, especially for people who use emojify.el for more than just slack.
Describe the bug
emojify-user-emojiscontains team-specific emojis from(oref team emoji-master)but does not have the default/built-in emojis fromslack-emoji-master.Team emojis are added to
emojify-user-emojishere, withinslack-download-emoji: https://github.com/yuya373/emacs-slack/blob/d53a57a18fb7034182c3d02503f937761e6a2a64/slack-emoji.el#L58-L62Whereas there is no equivalent logic in
slack-emoji-fetch-master-data(but there should be): https://github.com/yuya373/emacs-slack/blob/d53a57a18fb7034182c3d02503f937761e6a2a64/slack-emoji.el#L113-L133To Reproduce Steps to reproduce the behavior:
slack-insert-emoji:woman-shrand attempt to complete (via tab or whatever, depending on your completion config):woman-shrugging:Alternative steps:
:woman-shrugging:(type it out by hand, sinceslack-insert-emojidoesn't recognize it):woman-shrugging:is incorrectly shown as text instead of replaced by an emojiBacktrace Not applicable
Expected behavior Emojis from
slack-emoji-mastershould be added toemojify-user-emojisso that they can be inserted viaslack-insert-emojias well as rendered as an image instead of text in messages.Environment:
Additional context This is a slight tangent, but I noticed that emojis are added with style
"github". Would it make sense to change it to e.g."slack"instead? I think that would improve the UX since it would be more clear where the emojis are coming from, especially for people who useemojify.elfor more than just slack.