search

yuya373 / emacs-slack

slack client for emacs
1.11k stars 117 forks source link

emoji: take into account change in `emojify-completing-read` #529

Closed maurelio1234 closed 3 years ago

maurelio1234 commented 3 years ago

emojify-completing-read used to take as input a predicate that takes two arguments as input.

We seem to take the second argument containing something like :flag-yt: and we used it to look at slack-emoji-master to see if the emoji exists.

Now I takes a single argument which looks like:

":flag-yt: - Mayotte (github)

This does not match the contents of the cache anymore.

In this patch, I propose changing the format of the cache, to match the cache created by emojify, and then changing the lambda passed to emojify-completing-read to make take into account the new format of the list.

This patch is not complete yet, as we need to make sure (oref team emoji-master) is built with the same format.

maurelio1234 commented 3 years ago

This is a proposal to fix #517 @yuya373 I'd be willing to do the work necessary to finish this PR. What do you think about this approach? What would be the next steps? Perhaps I'd need to add a test?

yuya373 commented 3 years ago

fixed in 9cf38a4f0667be926f15e038ab347d9cc5d5d5ae thanks for pull request