search

yuya373 / emacs-slack

slack client for emacs
1.11k stars 117 forks source link

Add support for downloading files with `xoxc` tokens #559

Open isamert opened 2 years ago

isamert commented 2 years ago

slack-url-copy-file was not compatible with xoxc tokens which requires cookie to be present with the request. So this MR simply fixes that.

I only tested these changes with an xoxc token, so I'm not sure that it works with other tokens that do not require the cookie but there are no reasons for this to not work.

jsilve24 commented 2 years ago

Note, this fixes #558

Nazar65 commented 2 years ago

Please merge this PR bcs it's really useful fix :)

jsilve24 commented 2 years ago

Please merge

adamcstephens commented 2 years ago

I can confirm this fixes image downloading for me with an xoxc token.

unhammer commented 2 years ago

another happy user, this fixes it for me :grinning:

Konubinix commented 1 year ago

Works for me to. Thank you @isamert