search

yuya373 / emacs-slack

slack client for emacs
1.11k stars 117 forks source link

feat: Provide a nicer name for MPIM channels #576

Closed Konubinix closed 5 months ago

Konubinix commented 1 year ago

The one provided by slack mpdm-... contains only parts of the names of the members. It then is difficult to find MPIM channels using this name.

With this commit, the channel's name is composed of the name of all members, making it easier to find.

Konubinix commented 1 year ago

İsa Mert Gürbüz @.***> writes:

I would recommend using string-join function here instead of s-join as s.el is not a dependency of emacs-slack right now.

Done. Thank you. -- Konubinix GPG Key : 7439106A Fingerprint: 5993 BE7A DA65 E2D9 06CE 5C36 75D2 3CED 7439 106A

Konubinix commented 1 year ago

I messed up when moving to string-join. Now I fixed the code.

Konubinix commented 1 year ago

BUMPing this PR :-)

Konubinix commented 1 year ago

So far, I've been pretty satisfied with this change.

BUMPing it.

isamert commented 1 year ago

Hi @Konubinix, I don't think the maintainer is active and I don't think anybody has push access to this repository. I'm using your change in my local copy and it works well.

Konubinix commented 1 year ago

Thank you for your feedback

Konubinix commented 1 year ago

Hi. Just BUMPing it

Konubinix commented 1 year ago

BUMP, just in case

barleyj-opengov commented 1 year ago

I am also using your change in my local repo.

Konubinix commented 7 months ago

I'm glad this change helped people in here. I have moved to hosting the matrix homeserver conduit along with the Mautrix slack bridge and ement.el as client.

I'm closing this pull request now.

jumper047 commented 7 months ago

IMHO it is better to have it open - this code is useful, and open PR gives a hint to people who want to build their own slack from existing PRs

Konubinix commented 7 months ago

Fine with me