Fix wrong face attribute of box attribute.

yuya373 / emacs-slack

slack client for emacs

1.1k stars 117 forks source link

Fix wrong face attribute of box attribute. #587

Open ayatakesi opened 6 months ago

ayatakesi commented 6 months ago

Hello,

I instalked recent commit and try M-x slack-start, I got bellow error.

set-face-attribute: Invalid face box: :line-width, 1, :style, released-button, :foreground, "#2aa198"

This error occured due to wrong attribute :foreground. After correct specifying :color instead of :foreground, this error seems fixed.

Thanks.

sleep-walker commented 1 month ago

It seems, @isamert, that you're collecting open pull requests aleady, would you mind picking this up as well? it seems to be problem for Emacs 30. TIA

isamert commented 3 weeks ago

I'm not on Emacs 30 but I guess the patch also works on 29. Applied it, thanks for the heads up.