search

yuyang226 / ContactsWidgetICS

a contacts widget for Android 4.0 ICS(Ice Cream Sandwich)
26 stars 12 forks source link

Not an issue, only a suggest for Android repositories #4

Closed shawe closed 11 years ago

shawe commented 11 years ago

Can you move all files inside ContactsWidgetICS to the root of the project folder?

I integrate your widget to an opensource ROM and I must move all time that I sync the repo your folder ContactsWidgetICS/ContactsWidgetICS/ to ContactsWidgetICS/. This is not a problem only "an annoyance step", but I think that maybe you haven't got any problem to move this files, because finally you get the same structure an also you give the possibility that people easy use your widget with any Android compilation respecting a common way on github and Android repositories like this https://github.com/CyanogenMod/android_packages_apps_SoundRecorder

In case that you are interested on move the files for this reason, you can also add the file "Android.mk" with this content:

LOCAL_PATH:= $(call my-dir) include $(CLEAR_VARS)

LOCAL_MODULE_TAGS := optional

LOCAL_SRC_FILES := $(call all-subdir-java-files)

LOCAL_PACKAGE_NAME := ContactsWidgetICS LOCAL_CERTIFICATE := platform

include $(BUILD_PACKAGE)

Use the folloing include to make our test apk.

include $(call all-makefiles-under,$(LOCAL_PATH))

That give the option of compile it with any Android repository and also adding this line to a ".repo/local_manifest.xml":

yuyang226 commented 11 years ago

Thanks for the suggestion. How about I can grant you the Write permission, and you cut a branch to make the folder structure change. Please make sure you can have a link to my app Play Store link in your ROM.

By the way, I noticed that you are from Spain. Would you mind helping with the Spanish translation please?

yuyang226 commented 11 years ago

By the way, I noticed that all the other Android open sourced projects are not putting the code at the root. For instance, https://github.com/jfeinstein10/SlidingMenu. Thus I will keep my current folder structure.

shawe commented 11 years ago

Thanks for your answer ;)

shawe commented 11 years ago

Yes, I can help you with the spanish translation without problems, the only problem is that I don't know how to commit changes to a project that is not mine. If you can tell me I can do it the spanish translation for you :P

shawe commented 11 years ago

Some little corrections submitted for spanish translation using web options on github:

https://github.com/yuyang226/ContactsWidgetICS/pull/8