Closed daz-codersoft closed 2 years ago
hi Darryl , Thanks for your feedback! Do you wish not to Install-Package Hangfire.Dashboard.BasicAuthorization( IgnoreAntiforgeryToken = true), go by other way to ensure safety?
If that's the case, I think your proposal is a good idea, just configure the token in the hangfire server configuration file and verify it, then add a token field in the request body when adding it with Hangfire.HttpJob.Client.
How do you feel about this, or do you have a better suggestion
Thanks for the follow-up.
I'm far from an expert in security, so possibly the IgnoreAntiforgeryToken = true is a perfectly acceptable solution. But because it wasn't documented, it took me a long time to work out - I had to go through your regression tests closely and look for differences between our configurations. So my only issue is with your docs as they don't mention its use - a line in your Readme.md may save somebody else the time I spent.
I did just find https://github.com/HangfireIO/Hangfire/issues/1248 - near the bottom there is a mention to use IgnoreAntiforgeryToken so it must be the acceptable solution. So I would just suggest the simple documentation update.
Best regards, Darryl
This project is very useful to me. I have had HttpJob working fine for a while, but I now want to programmatically add jobs (I was adding them manually through the dashboard).
After several hours of tracking things through, I found two possible improvements to the instructions to help people get started:
Darryl