search

yuzutech / annotations-action

GitHub action to create annotations from a JSON file
MIT License
31 stars 15 forks source link

Annotations very often not visible #16

Open pun-ky opened 3 years ago

pun-ky commented 3 years ago

I am using also this annotations-action but on workflow_dispatch event. And even if the step finishes with a success, annotation is very often not visible / not attached to the "Jobs" area. Any ideas why?

ggrossetie commented 3 years ago

@pun-ky Can you please share a link to a job where annotations are not attached and a job where annotation are attached? PS: I removed your comment from #4 to avoid duplication.

pun-ky commented 3 years ago

It's on private github repo. Maybe this is a cause... Nothing special I've go there... What is also strange junit annotations step is also intermittently working ;/

ggrossetie commented 3 years ago

It's on private github repo. Maybe this is a cause... Nothing special I've go there... What is also strange junit annotations step is also intermittently working ;/

I think it's mostly related to how the annotations API is designed. I will try to run it using the workflow_dispatch event. Maybe in this scenario, the check run has no commit attached and as a result we cannot attach annotations.

pun-ky commented 3 years ago

Hmm. That make sense because maybe only to first run annotations are attached. And next runs are not having them. Yep. That fits to what I've observed.

potmo commented 9 months ago

I'm also seeing this on a private github repo that runs on PRs (annotating lint errors).