search

yuzutech / annotations-action

GitHub action to create annotations from a JSON file
MIT License
34 stars 15 forks source link

Annotations not attaching to changed files #19

Closed cmsj closed 3 years ago

cmsj commented 3 years ago

I've set up this action on two repos and while one is working perfectly, on the second one I'm seeing the annotations in the output of a PR workflow, but they're not being displayed in-line with the changed files, and I can't figure out what the issue is.

https://github.com/Hammerspoon/Spoons/pull/230 is an example PR to show this.

Hopefully you can see https://github.com/Hammerspoon/Spoons/pull/230/checks?check_run_id=2292390023 which shows the two expected annotations, but they aren't shown on https://github.com/Hammerspoon/Spoons/pull/230/files

I would very much appreciate any suggestions!

cmsj commented 3 years ago
Screenshot 2021-04-08 at 01 11 53

(just in case you can't see the second link there)

ggrossetie commented 3 years ago

Hey @cmsj

I think it only works if the line has changed in the commit. Here line 64 and 45 were not updated. Please note that the annotations API has several flaws. I wish I had more control but we have limited options 😞

cmsj commented 3 years ago

Thanks for the reply, I can live with that, and hope that one day the Annotations API will improve :)