search

yuzutech / annotations-action

GitHub action to create annotations from a JSON file
MIT License
31 stars 15 forks source link

Allow arbitrary json attributes to support GitHub's official format #6

Closed mohe2015 closed 3 years ago

mohe2015 commented 3 years ago

Not really intending to get this merged but more as a discussion. Obviously this would be a breaking change.

ggrossetie commented 3 years ago

Using GitHub format is a good idea but we can do it without breaking compatibility. If start_line or end_line is undefined, we can use line. Similarly, if path is undefined, then we can use file. I would also like to keep failure as a default value if annotation_level is missing or invalid.

Could you also please revert unrelated changes? I would prefer to replace require by import and update the dependencies in dedicated pull requests.

Thanks!

mohe2015 commented 3 years ago

@Mogztter This seems like the easiest way to achieve this. Let me know what you think please.

ggrossetie commented 3 years ago

@mohe2015 That's clever, I love it :+1: