search

yuzutech / annotations-action

GitHub action to create annotations from a JSON file
MIT License
31 stars 15 forks source link

Also run Github Actions on pull request #9

Closed mohe2015 closed 3 years ago

mohe2015 commented 3 years ago

This seems to not work yet as this PR is from a fork. According to https://docs.github.com/en/free-pro-team@latest/actions/reference/authentication-in-a-workflow#permissions-for-the-github_token you may need to create a token with the checks write permission but I don't know if this would be a security issue. EDIT: It seems like this is not currently possible so you would probably need to create a new account which just has access to this repo (which would probably be way too much effort for this). This still may be useful as it shows that it's at least working until this step (which is not optimal as the actual pushing can fail a lot of validation). I enabled actions for my fork so you could check it's checks.

ggrossetie commented 3 years ago

Yes that's the reason why I didn't enable it on pull requests. Even with a valid token, the check will be failing because we are adding annotations so it's a bit conter-intuitive.

ggrossetie commented 3 years ago

Having said that, we should probably add a new workflow to run the lint task. What do you think?

mohe2015 commented 3 years ago

Having said that, we should probably add a new workflow to run the lint task. What do you think?

I added it in https://github.com/yuzutech/annotations-action/pull/10 because that creates a valid linting result.